Skip to content

Move from POSIXError to URLError for URLSessionWebSocketTask #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Move from POSIXError to URLError for URLSessionWebSocketTask #4661

merged 1 commit into from
Nov 17, 2022

Conversation

pseligman
Copy link
Contributor

@pseligman pseligman commented Nov 17, 2022 •
edited
Loading

An alternative to rolling back WebSocketTask support (PR #4660)

Move from POSIXError to URLError for URLSessionWebSocketTask. URLErro…
6f6cbb9 
…r is suitable for use on Windows, whereas POSIXError is not
@pseligman
Copy link
Contributor Author

@swift-ci please test

@pseligman
Copy link
Contributor Author

CC: @compnerd @jrflat

@pseligman
Copy link
Contributor Author

@swift-ci please build toolchain windows platform

@pseligman pseligman mentioned this pull request Nov 17, 2022
Closed
@CodaFi CodaFi mentioned this pull request Nov 17, 2022
Merged
compnerd
compnerd approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CodaFi CodaFi merged commit 0787ce6 into swiftlang:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pseligman @compnerd @CodaFi