Skip to content

Revert "Implements URLSessionWebSocketTask" #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Implements URLSessionWebSocketTask" #4660

wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @pseligman

@compnerd compnerd mentioned this pull request Nov 17, 2022
Merged
@pseligman pseligman mentioned this pull request Nov 17, 2022
Merged
@pseligman
Copy link
Contributor

Hopefully we can leave the WebSocketTask support in place, and instead fix the Windows build. See PR #4661 . Apologies for not previously testing a Windows build, I was unaware swift-ci could do so. #4661 should include the magic incantation to kick one off.

@compnerd
Copy link
Member Author

This repository doesn't support that and needs to be kicked off from the swift repo. However, @CodaFi happened to do that in swiftlang/swift#62145 which verified that it does fix it. Closing in favour of #4661.

@compnerd compnerd closed this Nov 17, 2022
@compnerd compnerd deleted the revert-4643-URLSessionWebSocketTask branch November 17, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @pseligman