SR-11854: Fix concurrent operations execution in OperationQueue #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to run operations concurrently OperationQueue needs concurrent underlying DispatchQueue. This matches with Darwin.
|
cc @phausler — was this intended? |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Does this fix https://bugs.swift.org/browse/SR-11854 (OperationQueue not asynchronous) ? |
|
Oh, yes, exactly this case. |
compnerd
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
This seems reasonable to me, though it would be nice to have an additional test to validate the state of the dispatch queue if Foundation is built testable. That said, it would be beyond the scope of the particular fix, so I think that it is okay to do that as a follow-up.
|
CC: @tomerd - this is probably a good thing to grab for the upcoming release as well |
|
This will also need to go to 5.4 as well. I think #2930 may also need to be backported to 5.3 as well as its another |
This was referenced Dec 19, 2020
lxbndr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to run operations concurrently OperationQueue needs concurrent underlying DispatchQueue. This patch uses
.concurrentattribute to create DispatchQueues with required behavior.This matches with Darwin.