Fix OperationQueue scheduling logic to prevent disruption of operation lists #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n lists I believe the original intention was to adust `__nextPriorityOperation`. Doing so for `__nextOperation` has no sense and leads to crosslinking of the main operation list and corresponding priority operation list. OperationQueue in such state would crash or hang while attempting to schedule subsequent operation.
|
@swift-ci test |
|
Build errors look unrelated. @spevans could you please trigger new CI run? |
|
@swift-ci test linux |
compnerd
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperationQueue would crash or hang if we force "non-natural" execution order. E.g. when first operation depends on second.
The reason is how we work with internal operation lists in
OperationQueue._schedule(). I believe the original intention was to adjust__nextPriorityOperation, but instead we are modifying__nextOperation. This has no sense and leads to crosslinking of the main operation list and corresponding priority operation list. Subsequent scheduling would try to read already finished operation and hang. Also, at this point queue doesn't hold operation object anymore, so trying to read dead object is pretty realistic scenario.Suggested test case checks scenario described above, and ensures correct operation order as a bonus.