Skip to content

chore: fix docs build error #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022
Merged

chore: fix docs build error #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs-svelte-kit/tools/markdown-it-replace-link.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ export default (md: Md, options: { baseUrl: string; root: string }): void => {
if (/^https?:/.test(href)) {
const proxyToken = {
...token,
attrs: [...token.attrs!, ["target", "_blank"]],
attrs: [
...token.attrs!,
["target", "_blank"],
["rel", "noopener noreferrer"],
],
} as Token
return self.renderToken([proxyToken], 0, options)
} else if (/\.md(?:#.*)?$/.test(href) || /^#.*$/.test(href)) {
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/valid-prop-names-in-kit-pages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ At SvelteKit v1.0.0-next.405, instead of having multiple props corresponding to

## :wrench: Options

Nothing. But if use are using not default routes folder, please set configuration according to the [user guide](../user-guide.md#settings-kit).
Nothing. But if use are using not default routes folder, please set configuration according to the [user guide](../user-guide.md#settings-svelte-kit).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the build error locally 😓, but it was warned in the workflow, so I changed it.


## :books: Further Reading

Expand Down