Skip to content

chore: fix docs build error #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2022
Merged

chore: fix docs build error #292

merged 1 commit into from
Nov 2, 2022

Conversation

ota-meshi
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

⚠️ No Changeset found

Latest commit: 16d82a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

baseballyama
baseballyama approved these changes Nov 2, 2022
View reviewed changes
docs/rules/valid-prop-names-in-kit-pages.md
@@ -53,7 +53,7 @@ At SvelteKit v1.0.0-next.405, instead of having multiple props corresponding to

## :wrench: Options

Nothing. But if use are using not default routes folder, please set configuration according to the [user guide](../user-guide.md#settings-kit).
Nothing. But if use are using not default routes folder, please set configuration according to the [user guide](../user-guide.md#settings-svelte-kit).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the build error locally 😓, but it was warned in the workflow, so I changed it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ota-meshi
Copy link
Member Author

I couldn't reproduce the build error locally, so I'm not sure if this will fix it, but I'll try merging this.

@ota-meshi ota-meshi merged commit ed6e347 into main Nov 2, 2022
@ota-meshi ota-meshi deleted the docs-build branch November 2, 2022 00:44
@ota-meshi
Copy link
Member Author

It seems to have worked 😉.
I also fixed the links converted from markdown, so I was able to remove a lot of the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baseballyama baseballyama baseballyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @baseballyama