feat: add svelte/html-closing-bracket-spacing

[marekvospel]

Added html-closing-bracket-spacing rule, which can be seen in eslint-plugin-vue

Related PRs

feat: add svelte/html-self-closing #190
feat: add svelte/no-spaces-around-equal-signs-in-attribute #191

svelte/html-closing-bracket-spacing

A simple rule for enforcing a space before closing a tag

<div/>
<!-- gets fixed to -->
<div />

Coverage

100% test coverage.

Notes & questions

• This is my first time contributing to this project and creating eslint plugins in general, so I'm sorry if some parts of my code aren't as good.
• How should I document the rules? Is there a script to automatically generate the documentation, or should I create a new markdown file inside docs/rules? (This information should probably be added to contributing section in README)

[ota-meshi]

Thank you for this PR!
You need to add documents that describes the rules you added. After adding the files, run yarn update to update the header and footer.

[marekvospel]

@ota-meshi I've added the docs, fixed the merge conflicts and both the docs build and lint should be passing now!

[ota-meshi]

Thank you for adding the documentation! I'm busy this week so I'll probably check it next week.

[marekvospel]

I had extra time today, so I have added svelte/html-closing-bracket-spacing rule!

<div/>
# gets fixed to
<div />

It's similar to to svelte/no-spaces-around-equal-signs-in-attribute , but only has to check the end of the tag, so it's a bit simpler rule.

The test also has 100% coverage

I've also fixed some minor problems in my docs (such as since version being 0.2.2, which is already released, or mistyped <div />

[ota-meshi]

Thank you for this PR!

I have change requests.
I've looked at the source code for one rule, but I'll check the rest after tomorrow.

[ota-meshi]

If possible, can you separate the PR for each rule?
That way I can split the time to check the PR.

[ota-meshi]

If you want to create new rules besides these, you may find it useful to use yarn new new-rule-name.

[JounQin]

Hi @marekvospel Can you update this PR’s description align to its actual content?

[marekvospel]

Hi @marekvospel Can you update this PR’s description align to its actual content?

sure

[ota-meshi]

Thank you for changing this PR. Also, thank you for splitting the PR.
I commented only one. Other than that, it looks good to me.

[JounQin]

Personally thinking, styling rules should be extracted to another plugin like eslint-plugin-svelte-styling just like ESLint core has frozen their styling rules. We have prettier for .svelte or .vue files, although someone may not be using prettier, but another eslint-plugin-svelte-styling can help, so that styling rules can be excluded from this one.

[ota-meshi]

Hmm. I'm not sure if the stylistic rules should be an another plugin.
For now, I don't think it's necessary. Because the stylistic rules of the ESLint core are not yet another plugin.
But later my thinking may change.

[JounQin]

Because the stylistic rules of the ESLint core are not yet another plugin.

ESLint core has frozen their stylistic rules, no new related rule will be added, and no new feature for these rules will be added neither.

[ota-meshi]

I know that, but plugin for Svelte doesn't freeze the stylistic rules.
The ESLint core stylistic rules were used by many users and enhanced by many contributors until they froze. However, this plugin is not yet known to users and there are not enough stylistic rules.

---

If we continue to discuss what to do with stylistic rules, it may be better to open a new issue and discuss it there.

[ota-meshi]

LGTM!

[ota-meshi]

@marekvospel Thank you for your great contribution!
I merged and released the two rules 🎉
https://github.com/ota-meshi/eslint-plugin-svelte/releases/tag/v2.3.0

I will release the next version when the rest of the rules are complete.