Skip to content

Extract stylistic rules into another eslint plugin #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JounQin opened this issue Jul 21, 2022 · 5 comments
Closed

Extract stylistic rules into another eslint plugin #193

JounQin opened this issue Jul 21, 2022 · 5 comments
Labels
breaking change enhancement New feature or request

Comments

@JounQin
Copy link
Collaborator

JounQin commented Jul 21, 2022

It could be compatible but deprecate current stylistic rules.

From #186 (comment)

@JounQin JounQin added enhancement New feature or request breaking change labels Jul 21, 2022
@ota-meshi
Copy link
Member

I think the disadvantage of extracting a plugin for stylistic rules is that it makes it a little harder for users to find it.
So far I haven't seen a plugin for stylistic rules exist as a separate plugin in the ESLint plugin ecosystem.

I think the advantage is that there is no need to download stylistic rules, which is not necessary for users who have already introduced the formatter (prettier-plugin-svelte).

@eagerestwolf
Copy link

Sorry to stoke an old issue, but this is actually a growing trend in the world of ESLint plugins. There is actually a monorepo where all of the style rules are being moved to. So far, eslint-stylistic has collected the rules from ESLint, @typescript-eslint, and eslint-plugin-react. I think the Vue community is still clinging to their stylistic rules for now. If there is interest within the Svelte team, I could look into extracting the stylistic rules into a package in the eslint-stylistic monorepo (assuming they are also interested), and we could run both for a while to try to encourage the community to switch. Then (assuming it can be done in time), depreciate the rules with Svelte 5, maybe?

@eagerestwolf
Copy link

Don't panic about the issue title there. I am just running the idea of adding another package by the eslint-stylistic team before anyone really commits to anything. If they (and you) approve the change, I will work on moving the rules over and everything so that way you guys don't have to worry about it.

@marekdedic
Copy link
Contributor

FWIW, eslint-stylistic now have even in their docs that framework-specific rules are out-of-scope for them. So it would need to be a separate plugin (something like eslint-plugin-svelte-stylistic).

@baseballyama
Copy link
Member

This is a matter of decision, but we don’t want to double the maintenance cost by creating a separate plugin at this point. So, we will close this as “won’t do.”

@baseballyama baseballyama closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants