Skip to content

Updates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Updates #1

merged 2 commits into from
Aug 27, 2019

Conversation

ma-jahn
Copy link

@ma-jahn ma-jahn commented Aug 26, 2019

This PR covers the following:

Integration of PR's:

Updating Dependencies:

  • eslint 4.13.1 => 6.2.1
  • eslint-config-standard 11.0.0 => 14.0.1
  • eslint-plugin-import 2.13.0 => 2.13.0
  • eslint-plugin-node 7.0.1 => 9.1.0
  • eslint-plugin-promise 3.8.0 => 4.2.1
  • eslint-plugin-standard 3.1.0 => 4.0.1

@ma-jahn ma-jahn changed the title Feat/updating eslint Updates Aug 26, 2019
@ma-jahn ma-jahn requested a review from svewag August 26, 2019 14:18
Copy link

@svewag svewag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge Akryum#41 also

@svewag svewag merged commit 0d5aa37 into master Aug 27, 2019
@HerrBertling HerrBertling deleted the feat/updating_eslint branch August 27, 2019 06:54
@partounian
Copy link

@sumcumo @ma-jahn please take a look at the comment above 😄

Also thank you so much for doing all you've done so far

@ma-jahn
Copy link
Author

ma-jahn commented Sep 27, 2019

Hi @partounian

thank you for letting me know. Being honest i overlooked the request. I'll start right now and a update will be available very soon ;)

@svewag
Copy link

svewag commented Sep 27, 2019

But isn't it already merged?

https://github.com/sumcumo/vue-cli-plugin-ssr/blob/master/lib/dev-server.js#L122

@ma-jahn
Copy link
Author

ma-jahn commented Sep 27, 2019

Yes it is. #2

Just haven't tagged it here but it was published within 0.6.0.
I'll now go through all open MR's ;)

@partounian
Copy link

partounian commented Sep 27, 2019 via email

@partounian
Copy link

I can't figure out how to use vue add with this, or install it manually then use vue invoke. Any chance somehow can tell me how to use this package?

@ma-jahn
Copy link
Author

ma-jahn commented Sep 28, 2019

Yeah.. You need to set it up manually. There is a bug within vue shared utils which doesn't allow package scopes containing a dot. Therefore our package can not be detected.
Our MR was already merged but not yet released.

I am currently in vacation and will update our Readme to show you what you need to do.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants