feat(onError): adding basic onError cb #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(copy_url_on_start): integrate mr
Update chalk: 2.4.1 → 2.4.2 (patch)
Update compression: 1.7.3 → 1.7.4 (patch)
Update portfinder: 1.0.20 → 1.0.23 (patch)
…port-2.18.2 Update eslint-plugin-import: 2.14.0 → 2.18.2 (minor)
….2.1 Update webpack-merge: 4.1.5 → 4.2.1 (minor)
Update loader-utils: 1.1.0 → 1.2.3 (minor)
Update express: 4.16.4 → 4.17.1 (minor)
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
Chore/npm
Chore/vuepress
Update webpack-merge: 4.2.1 → 4.2.2 (patch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to log errors occurring on the server we found it helpful to have a simple cb within the renderToString error Callback.
With this little callback we can now use our own logger to log errors occurring within renderToString.