This repository was archived by the owner on May 14, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Wrap non-CssSyntaxError into stylelint results #211
Merged
emilgoldsmith
merged 5 commits into
styled-components:master
from
chinesedfan:better_error_handler
Sep 17, 2018
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
83e9881
Wrap non-CssSyntaxError into stylelint results
chinesedfan e804120
Merge branch 'master' into better_error_handler
chinesedfan 99d1b3b
make the inserted parseError follow stylelint$warning
chinesedfan 2a14888
Merge branch 'master' into better_error_handler
chinesedfan 36fe4e6
Update invalid fixture as the parser is updated
chinesedfan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import * as React from 'react'; | ||
import styled, { keyframes } from 'styled-components'; | ||
|
||
export interface IAccordionContainerProps { | ||
className?: string; | ||
borderWidth: number, | ||
onChange?(id: string): void; | ||
} | ||
export interface IAccordionContainerState { | ||
selected: string; | ||
} | ||
|
||
export const AccordionContainerDiv = styled.div<{ width#: string }>` | ||
border: solid ${(props: IAccordionContainerProps) => props.borderWidth}px; | ||
border-bottom-width: 0; | ||
width: auto; | ||
`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get displayed to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Node.js API users, it is yes. But I found CLI didn't print very pretty output. The latest commit fixes it.