This repository was archived by the owner on May 14, 2021. It is now read-only.
Wrap non-CssSyntaxError into stylelint results #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return stylelintResult | ||
| } else { | ||
| // For other errors, wrap them into the result | ||
| return Object.assign({}, stylelintResult, { |
There was a problem hiding this comment.
Does this get displayed to the user?
There was a problem hiding this comment.
For Node.js API users, it is yes. But I found CLI didn't print very pretty output. The latest commit fixes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning, this processor will throw every error to stylelint. But stylelint can only handle
CssSyntaxError. (#131)After #142, non-CssSyntaxErrors are ignored, which causes some confusions(#204, #210).
I think we should wrap those errors into stylelint results. So that both requirements are met.