This repository was archived by the owner on May 14, 2021. It is now read-only.
Remove extra npm install #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. npm@2 will fail with unmet peer dependencies, while npm@3+ will not. And the greenkeeper has stopped working to upgrade stylelint to fix this problem. |
|
Hmm, node v4 is not LTS anymore either though, and I know many major packages have stopped supporting it, so maybe we should also just remove it from our CI? |
|
Sure, I can revert those nodejs@4 related commits this weekend. |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually,
npmis installed withnodejs. And latest [email protected] is not compatible with nodejs@4, which will break our CI.