Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

Add 'optionalChaining' to babylon-parser #189

Merged
merged 2 commits into from
May 26, 2018

Conversation

chrishelgert
Copy link
Contributor

As discussed in #183 this will be the first quick fix with adding optionalChainging to the plugin list.

@chrishelgert
Copy link
Contributor Author

if i should add an test, it would be great to know if i should add it to an existing spec or create a new one for this 👍

@emilgoldsmith
Copy link
Member

I don't think a test is needed for this, it's pretty simple :). I'll just merge it in, thanks for the contribution, it's always appreciated no matter the size :).

@emilgoldsmith
Copy link
Member

It seems like we need to fix CI first as addressed in #190, then I'll merge it in right away

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.635% when pulling ad7dd7e on chrishelgert:patch-1 into 379177d on styled-components:master.

@emilgoldsmith emilgoldsmith merged commit fe36e26 into styled-components:master May 26, 2018
@mxstbr
Copy link
Member

mxstbr commented May 26, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

@rainboxx
Copy link
Member

Could we have this in a release, please? 🙂

@emilgoldsmith
Copy link
Member

Oh we never released this? Sorry if so, I'll try and remember this weekend, if I forget please feel free to remind me again

@emilgoldsmith
Copy link
Member

@rainboxx published as 1.3.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants