Update dependency and test command for PhantomJS #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2016
|
@slnode test please |
|
@davidcheung LGTM, should we go ahead and land this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to #215
The resolution to an error when running "npm test" is to update the PhantomJS dependency to PhantomJS2.
Background
Current angular dependency is defined:
"angular": "^1.4.9"
With the release of angular 1.5 there are errors loading angular in PhantomJS that affect this repo's default test command.
Original Issue not addressed in PhantomJS 1.0: ariya/phantomjs#10522
Recent discussion specific to angular 1.5: angular/angular.js#13794
Error Message: