-
Notifications
You must be signed in to change notification settings - Fork 82
Update dependency and test command for PhantomJS #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
@slnode okay to test |
I can confirm that the current phantomJS doesnt install properly, you need to change |
@scalarsys Thanks for the patch! |
I have signed the CLA but had problems with SL team members seeing that I have signed it on another PR. When I go to https://cla.strongloop.com/agreements if shows that I have signed the agreement for loopback-sdk-angular. Let me know if you need me to do anything to clear up the CLA issue. |
Oh, I believe its because the commit it under @jeff-clegg, therefore the CLA check isnt passing. |
Ok, my mistake, I signed CLA as @jeff-clegg. |
@scalarsys would you be able to rebase the changes on top of current master please? |
Can one of the admins verify this patch? |
Not sure if I did the rebase correctly, sorry if this is too much trouble. |
sorry my fault, since I took so long to reply, might have been a better idea to just fetch the latest and redo it on the origin/master. |
@scalarsys Thanks for your PR i have landed via #231 |
The resolution to an error when running "npm test" is to update the PhantomJS dependency to PhantomJS2.
Background
Current angular dependency is defined:
"angular": "^1.4.9"
With the release of angular 1.5 there are errors loading angular in PhantomJS that affect this repo's default test command.
Original Issue not addressed in PhantomJS 1.0: ariya/phantomjs#10522
Recent discussion specific to angular 1.5: angular/angular.js#13794
Error Message: