Skip to content

Add new official library.properties field for static linking flags in platform.txt compiler recipe. #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

kent-williams
Copy link
Contributor

@kent-williams kent-williams commented Oct 22, 2019

Summary

This PR implements the following features

  • Add compiler.libraries.ldflags variable to platform.txt

This adds the ability to link against statically compiled library files in Arduino Libraries using the precompiled and ldflags keys described here.

Closing issues

Fixes #606 which I do not believe was fully fixed by #629

@fpistm fpistm self-requested a review October 23, 2019 07:33
@fpistm fpistm added this to the 1.8.0 milestone Oct 23, 2019
@fpistm
Copy link
Member

fpistm commented Oct 23, 2019

Hi @kent-williams
Thanks for this PR.
You're right, I thought it was handled by Arduino when processing library.

@fpistm fpistm merged commit 1811b50 into stm32duino:master Oct 23, 2019
@kent-williams kent-williams deleted the patch-1 branch October 23, 2019 13:28
@kent-williams
Copy link
Contributor Author

@fpistm Are there plans to do a release soon? We have a large project launching soon that requires this addition. Happy to help in anyway I can!
Thanks!!

@fpistm
Copy link
Member

fpistm commented Nov 7, 2019

I do a release each quarter. I've planned to do 1.8.0 in December. Anyway as soon as I end the issue set as milestone 1.8.0, I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support precompiled libraries
2 participants