Skip to content

Fix {build.mcu} definition #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Sep 3, 2019

Library can provide a pre-compiled library.
See precompiled option here:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-format

The .a(archive)/.so(shared object) file must be located at: src/{build.mcu}

So the build.mcu could not contain fpu and float-abi options
and should only contain cortex-mx value.

Else Arduino IDE, instead of searching cortex-mx, searches
cortex-mx -mfpu=fpv4-sp-d16 -mfloat-abi=hard if floating-point
options are set.

build.flags.fp has been added to contain floating-point options if any.

Fixes #606

Library can provide a precompiled library.
See precompiled option here:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-format

The .a(archive)/.so(shared object) file must be located at: `src/{build.mcu}`

So the `build.mcu` could not contain `fpu` and `float-abi` options
and should only contain `cortex-mx` value.

Else Arduino IDE, instead of searching `cortex-mx`, searches
`cortex-mx -mfpu=fpv4-sp-d16 -mfloat-abi=hard` if floating-point
options are set.

`build.flags.fp` has been added to contain floating-point options if any.

Fixes stm32duino#606

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm added enhancement New feature or request arduino compatibility fix 🩹 Bug fix labels Sep 3, 2019
@fpistm fpistm added this to the 1.7.0 milestone Sep 3, 2019
@fpistm fpistm self-assigned this Sep 3, 2019
@fpistm fpistm merged commit 70b8bce into stm32duino:master Sep 4, 2019
@fpistm fpistm deleted the precompiled_library_support branch September 4, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support precompiled libraries
1 participant