-
Notifications
You must be signed in to change notification settings - Fork 1k
New Variant - HY-TinySTM103T #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've purchased a couple of boards just out of interest. |
About Flash menu, it could be removed and instead use the ld preprocess I guess |
Wouldn't that mean multiple choices in the board entry though? How else would it know which size had been selected? |
Right anyway, I think it should be fine to rename it GenF1. Then as I've done for GenF4 factorize some common line per boards definition (d86b19a) |
OK, well I'll leave that bit to you 🤣 |
Done in #418 ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found in pin mapping (linked to PB2 definition)
Anyway thanks for this variant ;)
Moreover, we will wait that some tests can be performed. |
No problem I'll fix the pin map tonight. I've asked the requester to test - he may have issues until I commit later 🤣 |
@BennehBoy Still one issue if I'm not wrong ;) |
I think I've sorted this now.... |
Congratulations 👍 PR is cleaned. |
Even if not tested, I've merged it. If any issue is found then we will correct it. |
Fix #413 |
My boards are coming airmail from Singapore so I should be able to test this soon if the original requester does not respond. |
I'm going to try this out on one of my test boards today and tomorrow -- if all goes well I'll let it soak running the mysensors application to see how it performs (found a problem in the SPI.cpp file in Roger's version). |
Adding support for HY-Tiny103T board -> http://wiki.stm32duino.com/index.php?title=HY-TinySTM103T
I've added this to the Generic 103 section of boards.txt which means it inherits the 64/128KB flash selection, either selection will result in the variant being correctly linked for 128KB, but the Arduino IDE will incorrectly report max ram/flash sizes during build if 64K is selected.
No local testing done...
Could do with Arduino A0/PA0 equivalence testing & the usual checks.