Skip to content

New Variant - HY-TinySTM103T #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2019
Merged

New Variant - HY-TinySTM103T #416

merged 4 commits into from
Jan 31, 2019

Conversation

BennehBoy
Copy link
Contributor

Adding support for HY-Tiny103T board -> http://wiki.stm32duino.com/index.php?title=HY-TinySTM103T

I've added this to the Generic 103 section of boards.txt which means it inherits the 64/128KB flash selection, either selection will result in the variant being correctly linked for 128KB, but the Arduino IDE will incorrectly report max ram/flash sizes during build if 64K is selected.

No local testing done...

Could do with Arduino A0/PA0 equivalence testing & the usual checks.

@BennehBoy
Copy link
Contributor Author

I've purchased a couple of boards just out of interest.

@fpistm fpistm self-requested a review January 25, 2019 13:03
@fpistm fpistm added the new variant Add support of new bard label Jan 25, 2019
@fpistm
Copy link
Member

fpistm commented Jan 25, 2019

About Flash menu, it could be removed and instead use the ld preprocess I guess

@BennehBoy
Copy link
Contributor Author

About Flash menu, it could be removed and instead use the ld preprocess I guess

Wouldn't that mean multiple choices in the board entry though? How else would it know which size had been selected?

@fpistm
Copy link
Member

fpistm commented Jan 25, 2019

Right anyway, I think it should be fine to rename it GenF1. Then as I've done for GenF4 factorize some common line per boards definition (d86b19a)

@BennehBoy
Copy link
Contributor Author

OK, well I'll leave that bit to you 🤣

@fpistm
Copy link
Member

fpistm commented Jan 25, 2019

Done in #418 ;)

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found in pin mapping (linked to PB2 definition)
Anyway thanks for this variant ;)

@fpistm
Copy link
Member

fpistm commented Jan 29, 2019

Moreover, we will wait that some tests can be performed.

@BennehBoy
Copy link
Contributor Author

No problem I'll fix the pin map tonight.

I've asked the requester to test - he may have issues until I commit later 🤣

@fpistm
Copy link
Member

fpistm commented Jan 30, 2019

@BennehBoy Still one issue if I'm not wrong ;)
As an extra you can try to rebase it properly as an exercise 😜

@BennehBoy
Copy link
Contributor Author

I think I've sorted this now....

@fpistm
Copy link
Member

fpistm commented Jan 30, 2019

Congratulations 👍 PR is cleaned.

@fpistm fpistm merged commit 1e3846f into stm32duino:master Jan 31, 2019
@fpistm
Copy link
Member

fpistm commented Jan 31, 2019

Even if not tested, I've merged it. If any issue is found then we will correct it.

@fpistm
Copy link
Member

fpistm commented Jan 31, 2019

Fix #413

@BennehBoy BennehBoy deleted the HYTINY branch January 31, 2019 08:09
@BennehBoy
Copy link
Contributor Author

My boards are coming airmail from Singapore so I should be able to test this soon if the original requester does not respond.

@mitchmitchell
Copy link

I'm going to try this out on one of my test boards today and tomorrow -- if all goes well I'll let it soak running the mysensors application to see how it performs (found a problem in the SPI.cpp file in Roger's version).

benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants