Skip to content

[EEPROM] Wrong E2END definition #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[EEPROM] Wrong E2END definition #400

merged 1 commit into from
Jan 4, 2019

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jan 3, 2019

E2END is the last valid EEPROM address.
Fix #396

E2END is the last valid EEPROM address.
Fix stm32duino#396

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm fpistm mentioned this pull request Jan 3, 2019
@fpistm fpistm self-assigned this Jan 3, 2019
@fpistm fpistm added the fix 🩹 Bug fix label Jan 3, 2019
@fpistm fpistm added this to the 1.5.0 milestone Jan 3, 2019
@fpistm
Copy link
Member Author

fpistm commented Jan 3, 2019

@mayurharge let me know if it is ok.
you can also test by adding -1 to EEPROM_SIZE in your sketch

@fpistm fpistm merged commit 5cc5415 into stm32duino:master Jan 4, 2019
@fpistm fpistm deleted the E2END branch January 4, 2019 07:54
@mayurharge
Copy link

@fpistm yea its working fine, I Have made changes according to this link
https://github.com/stm32duino/Arduino_Core_STM32/commit/5cc5415ca2e7c9906bfa29aee923a7f0d90c5473
Thanks once again.

benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
[EEPROM] Wrong E2END definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants