Skip to content

EEPROM Reset issue #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayurharge opened this issue Dec 25, 2018 · 7 comments
Closed

EEPROM Reset issue #396

mayurharge opened this issue Dec 25, 2018 · 7 comments
Assignees
Labels
bug 🐛 Something isn't working
Milestone

Comments

@mayurharge
Copy link

Hello,
I am using EMBEDIS library for handling EEPROM related functions.
I am getting the proper response for the first startup. but I am not able to retain the values after a restart.
the code works fine with [http://dan.drown.org/stm32duino/package_STM32duino_index.json]
board files.
Thanks

@fpistm
Copy link
Member

fpistm commented Dec 25, 2018

I guess you used the Bluepill? could you be more precise ? Sketch? build option...

@mayurharge
Copy link
Author

mayurharge commented Dec 25, 2018

Yes i have used controller from bluepill. stm32f103c series 128kb version.
Build options were default Just changed the upload method to serial and controller size to 128 kb.

Here is the link for sketch

https://github.com/thingSoC/embedis/blob/master/examples/Uno/Embedis_Uno/Embedis_Uno.ino

Here is the exact build config
Board "stm32f103c series"
board part no "Bluepill F103c8"
Seril interface "Enabled with generic serial"
optimize "Smallest(-Os default)"
Cruntime Library "Newlib Nano(default)"
flash memory size: "128K"

@mayurharge
Copy link
Author

@fpistm
Please Update on this.
Thanks.

@fpistm
Copy link
Member

fpistm commented Dec 28, 2018

I will not be able to test before next week. Anyway, last time I've tested the eeprom emulation on F1 it was functionnal. I saw some core define usage in the lib maybe there is a small update to do also in the lib.
Did you test default eeprom example which do not use the lib? (Put and get example)

@mayurharge
Copy link
Author

mayurharge commented Dec 28, 2018 via email

fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jan 3, 2019
E2END is the last valid EEPROM address.
Fix stm32duino#396

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm
Copy link
Member

fpistm commented Jan 3, 2019

Hi @mayurharge
I've been able to test and reproduce.
In fact value are not reset and well present in the FLASH after a reset. (I've dump the flash)
Issue come from a wrong E2END definition. As EMBEDIS store since the end of the EEPROM it miss one data as E2END was defined as the SIZE instead of the last valid address.
Now it is working with #400

@fpistm fpistm self-assigned this Jan 3, 2019
@fpistm fpistm added the bug 🐛 Something isn't working label Jan 3, 2019
@fpistm fpistm added this to the 1.5.0 milestone Jan 3, 2019
@mayurharge
Copy link
Author

Thanks.

benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this issue Apr 10, 2019
E2END is the last valid EEPROM address.
Fix stm32duino#396

Signed-off-by: Frederic.Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants