Skip to content

Configure Swan R5 initial behaviors #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Sep 15, 2021

After putting the Swan through it's paces, we decided it would make a better experience to modify the following behaviors.

chore: Enable Swan I2C pull-ups by default

feat: Improve Swan 3V3 pin control/behavior

  • Define constant to reference DISCHARGE_3V3 pin.
  • Define constants ENABLE_DISCHARGING and DISABLE_DISCHARGING to manipulate DISCHARGE_3V3 pin.
  • Initialize ENABLE_3V3 pin to be on, and DISCHARGE_3V3 to be disabled.

- Define constant to reference `DISCHARGE_3V3` pin.
- Define constants `ENABLE_DISCHARGING` and `DISABLE_DISCHARGING` to manipulate `DISCHARGE_3V3` pin.
- Initialize `ENABLE_3V3` pin to be on, and `DISCHARGE_3V3` to be disabled.
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the enhancement New feature or request label Sep 15, 2021
@fpistm fpistm added this to the 2.1.0 milestone Sep 15, 2021
@fpistm fpistm merged commit 6dec3b6 into stm32duino:master Sep 15, 2021
ABOSTM pushed a commit to ABOSTM/Arduino_Core_STM32 that referenced this pull request Sep 22, 2021
Configure Swan R5 initial behaviors
@zfields zfields deleted the swan_r5 branch February 28, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants