Skip to content

Remove I2C buffer length limitation required by M24SR64-Y library #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove I2C buffer length limitation required by M24SR64-Y library #120

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2017 •
edited by ghost
Loading

The M24SR64-Y library needs an I2C buffer of 255 bytes.
So we must to give the possibility to increase the I2C buffer size.

@ghost ghost mentioned this pull request Oct 2, 2017
Merged
@ghost ghost requested review from fpistm and VVESTM October 2, 2017 11:30
fpistm
fpistm reviewed Oct 2, 2017
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be better that a library which request a buffer > 32, change the I2C buffer size of the instance it used instead of impacting all. Mostly when this lib is not used.

@fpistm fpistm mentioned this pull request Oct 4, 2017
Closed
@fpistm fpistm assigned ghost Oct 10, 2017
@ghost ghost mentioned this pull request Oct 11, 2017
Closed
@ghost
Copy link
Author

ghost commented Oct 11, 2017

#131 should remove this PR. I have to rework the NFC library to use the new methods of the Wire library.

@fpistm fpistm added duplicate This issue or pull request already exists invalid This doesn't seem right labels Oct 11, 2017
@fpistm fpistm removed the request for review from VVESTM October 11, 2017 12:29
@fpistm fpistm removed duplicate This issue or pull request already exists invalid This doesn't seem right labels Oct 11, 2017
fpistm
fpistm reviewed Oct 11, 2017
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be abandoned. New implementation will be done. See #131

@fpistm fpistm added the invalid This doesn't seem right label Oct 17, 2017
@fpistm fpistm closed this Oct 17, 2017
@ghost ghost deleted the i2c_redefine_buffer_length branch November 8, 2017 14:37
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fpistm