Skip to content

I2C needs to be reworked to use IT mode #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Oct 4, 2017 · 2 comments
Closed

I2C needs to be reworked to use IT mode #123

ghost opened this issue Oct 4, 2017 · 2 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 4, 2017

The I2C layer needs some patches (twi.c in core):

  • IRQHandler name do not match for F0 & L0
  • ER_IRQn needs to be attached for all boards (except F0 & L0)
  • Errors need to be taken account in master_read & master_write
  • Error Callback must be reviewed to work in slave & master mode
  • Other (to see)?
@ghost ghost added the enhancement New feature or request label Oct 4, 2017
@fpistm fpistm changed the title I2C needs to be reworked I2C needs to be reworked since IT used Oct 4, 2017
@fpistm
Copy link
Member

fpistm commented Oct 4, 2017 •
edited
Loading

Buffer size could be reviewed to avoid #120. Handled by #124

@fpistm
Copy link
Member

fpistm commented Oct 4, 2017

FYI: I've revert the commit which introduce I2C IT:
625fe2d

Let's reintroduced this thanks this issue solving.

@fpistm fpistm changed the title I2C needs to be reworked since IT used I2C needs to be reworked to use IT mode Oct 4, 2017
@fpistm fpistm mentioned this issue Oct 4, 2017
Merged
@ghost ghost mentioned this issue Oct 12, 2017
Merged
@ghost ghost self-assigned this Oct 16, 2017
@ghost ghost mentioned this issue Oct 17, 2017
Merged
@fpistm fpistm closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fpistm