Skip to content

Winterrupts.c writes but never reads .configured #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fpistm opened this issue Jun 2, 2017 · 2 comments
Closed

Winterrupts.c writes but never reads .configured #6

fpistm opened this issue Jun 2, 2017 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fpistm
Copy link
Member

fpistm commented Jun 2, 2017

From @rogerclarkmelbourne on November 20, 2016 21:11

In various lines Winterrupts.c e.g.

https://github.com/stm32duino/Arduino_Core_STM32L4/blob/master/cores/arduino/WInterrupts.c#L43

.configured is written but never read.

These lines can be removed and

PinDescription g_intPinConfigured[MAX_DIGITAL_IOS];

can be changed to a array of pointers to PinDescription

(and the code changed accordingly)

Copied from original issue: fpistm/Arduino_Core_STM32L4#4

@fpistm
Copy link
Member Author

fpistm commented Jun 2, 2017

From @fprwi6labs on January 10, 2017 10:26

g_intPinConfigured can be changed to a pointer.

I think the parameter "configured" is not well used in the entire code. I don't know if this parameter is really useful. For the moment we keep it.

@fpistm
Copy link
Member Author

fpistm commented Jun 2, 2017

From @rogerclarkmelbourne on January 10, 2017 21:43

We have made a lot of changes to the F1 which probably include changes to this.

The complicated pin mapping function have been simplified etc

Ideally the code for the different MCU series would not differ too much, and perhaps the L4 code should be updated to be more like the revised F1 code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant