Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Winterrupts.c writes but never reads .configured #4

Closed
rogerclarkmelbourne opened this issue Nov 20, 2016 · 3 comments
Closed

Winterrupts.c writes but never reads .configured #4

rogerclarkmelbourne opened this issue Nov 20, 2016 · 3 comments

Comments

@rogerclarkmelbourne
Copy link
Contributor

In various lines Winterrupts.c e.g.

https://github.com/stm32duino/Arduino_Core_STM32L4/blob/master/cores/arduino/WInterrupts.c#L43

.configured is written but never read.

These lines can be removed and

PinDescription g_intPinConfigured[MAX_DIGITAL_IOS];

can be changed to a array of pointers to PinDescription

(and the code changed accordingly)

@ghost
Copy link

ghost commented Jan 10, 2017

g_intPinConfigured can be changed to a pointer.

I think the parameter "configured" is not well used in the entire code. I don't know if this parameter is really useful. For the moment we keep it.

@rogerclarkmelbourne
Copy link
Contributor Author

We have made a lot of changes to the F1 which probably include changes to this.

The complicated pin mapping function have been simplified etc

Ideally the code for the different MCU series would not differ too much, and perhaps the L4 code should be updated to be more like the revised F1 code.

@fpistm
Copy link
Owner

fpistm commented Jun 2, 2017

This issue was moved to stm32duino/Arduino_Core_STM32#6

@fpistm fpistm closed this as completed Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants