Skip to content

Fix swift package build #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Fix swift package build #1061

merged 2 commits into from
Aug 18, 2021

Conversation

jberkel
Copy link
Collaborator

@jberkel jberkel commented Aug 18, 2021

Fixes #1058

@jberkel jberkel changed the title Fix swit package build Fix swift package build Aug 18, 2021
@nathanfallet
Copy link
Collaborator

Waiting for checks to complete before merging it (hope it will work)

@jberkel
Copy link
Collaborator Author

jberkel commented Aug 18, 2021

hmm, maybe we should disable the pods tests on regular builds, they take forever. they could be run before releasing.

@nathanfallet
Copy link
Collaborator

Let's keep them as it for now. At least we'll be sure everything works. And when a PR is opened, we don't see it directly so it has enough time to build everything.

@nathanfallet nathanfallet merged commit 3dce02e into master Aug 18, 2021
@nathanfallet nathanfallet deleted the fix-spm branch August 18, 2021 23:08
@nathanfallet
Copy link
Collaborator

@jberkel Now we have to publish a new release (for xcode support and fixes mainly).
Also, DM me on Twitter @NathanFallet so that we can talk about everything easily.

@jberkel
Copy link
Collaborator Author

jberkel commented Aug 19, 2021

@nathanfallet don't have twitter, I'll send you an email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to GitHub Actions (instead of travis-ci.org)
2 participants