Skip to content

Move to GitHub Actions (instead of travis-ci.org) #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathanfallet opened this issue Aug 18, 2021 · 7 comments · Fixed by #1059 or #1061
Closed

Move to GitHub Actions (instead of travis-ci.org) #1058

nathanfallet opened this issue Aug 18, 2021 · 7 comments · Fixed by #1059 or #1061

Comments

@nathanfallet
Copy link
Collaborator

The old travis.org service is no longer available.
You need to activate something in order to move the CI to travis-ci.com. PRs won't be able to get merged otherwise

@nathanfallet
Copy link
Collaborator Author

@stephencelis It's an important point, it takes about 5 minutes, and you are the only one having the permission to do it.

@nathanfallet
Copy link
Collaborator Author

nathanfallet commented Aug 18, 2021

@jberkel I talked with Stephen today, and we concluded we had to move to GitHub Actions. We still have an unresolved error with Swift Package Manager test command swift test. Any idea of where it could come from? (all the rest is working, and this command was working previously on Travis)

image

@nathanfallet nathanfallet reopened this Aug 18, 2021
@nathanfallet nathanfallet changed the title Move to travis-ci.com (instead of travis.org) Move to GitHub Actions (instead of travis-ci.org) Aug 18, 2021
@jberkel
Copy link
Collaborator

jberkel commented Aug 18, 2021

@nathanfallet thanks, I'll take a look. I saw that you merged some PRs, wouldn't it be better to sort out the CI before merging more code?

@nathanfallet
Copy link
Collaborator Author

nathanfallet commented Aug 18, 2021

@jberkel I only merged PRs about documentation (no CI needed) and little additions like conforming types (e.g. UUID or Int64) to codable things. I checked, and all tests are passing (except the SPM one, but others driven by Cocoapods or Carthage did), but yes, for other PRs we need to fix the CI first.

@nathanfallet
Copy link
Collaborator Author

Could the SPM build error be related to #1051?

@jberkel
Copy link
Collaborator

jberkel commented Aug 18, 2021

Yes, I found the problem will open a PR soon. Some of the last merged PRs broke the tests

@nathanfallet
Copy link
Collaborator Author

nathanfallet commented Aug 18, 2021

@jberkel Okay, waiting for the fix (also mark you PR to close this issue)
And I just fixed what was broken by one of the last PR, because it had a conflict with another change, so even the old travis success check was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants