Updates for Xcode 12.5 #1051
Merged
Updates for Xcode 12.5 #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BennettSmith
commented
May 18, 2021
BennettSmith
commented
- Updates ruby version used by Travis-CI.
- Updates Xcode image to 12.5 for Travis-CI.
- Removes workaround in run-tests.sh for older simulators.
- Updates Carthage toolchain.
- Updates Package.swift tool version.
- Fixes up SPM build for SQLiteObjc module.
* Updates ruby version used by Travis-CI. * Updates Xcode image to 12.5 for Travis-CI. * Removes workaround in run-tests.sh for older simulators. * Updates Carthage toolchain. * Updates Package.swift tool version. * Fixes up SPM build for SQLiteObjc module. * Updated Xcode build settings.
|
@stephencelis The changes in this PR address some build failures of the AWS AppSync SDK that depends on SQLite.Swift. Please take a look and let me know if there are any changes you would like to see. The issue was that when building the AWS AppSync SDK using Swift Package Manager on Xcode 12.5 it would fail to build the SQLiteObjc module. That is now working with these changes. I also fixed Travis-CI failures when running the tests. |
|
@stephencelis Is there anything I can do to help with getting this merged? If it's missing something please let me know. Thanks. |
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.