Parsing caching #43
Closed
Parsing caching #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2016 21:34
-- Currently stacktrace-gps does parsing of same file multiple times
if stack trace refers to same file. It becomes a problem when there
is a single huge js file and complete stack trace is from that file.
It can be optimized by caching parsing results and reuse it whereever required.
In this commit I am making code changes to cache costly prcoessing on source map
|
@abhinavsinghvi Thanks for the PR. I'm afraid I'm not able to really use it because there are a few issues:
I have implemented the requested behavior in e173aff so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have also faced issue similar to #41.
I have found that when stack trace is coming from single huge js file it becomes very costly to generate source map stack trace as it seems currently stacktrace-gps is doing costly processing multiple time, to avoid that I have made changes to caching parsing results and re use them if required.
How Has This Been Tested?
Tested in my application and have seen almost 80% performance improvement while generating source map stack trace of error.
Checklist: