Skip to content

Bluebird Promise Warnings #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlucool opened this issue Apr 12, 2016 · 2 comments
Closed

Bluebird Promise Warnings #35

mlucool opened this issue Apr 12, 2016 · 2 comments

Comments

@mlucool
Copy link

mlucool commented Apr 12, 2016

Hi,

When I try this (via stacktrace.js) with webpack + bluebird promise I see the following warning:
"Warning: a promise was created in a handler but was not returned from it"

The warning seems to think its coming from:
https://github.com/stacktracejs/stacktrace-gps/blob/master/stacktrace-gps.js#L172
StackTraceGPS: this._get = function _get(location) {

See: https://github.com/petkaantonov/bluebird/blob/master/docs/docs/warning-explanations.md#warning-a-promise-was-created-in-a-handler-but-none-were-returned-from-it

If this code is correct, can be it explicit so make bluebird not warn?

@mlucool
Copy link
Author

mlucool commented Jun 14, 2016

Hi @eriwen any thoughts on this?

abhinavsinghvi pushed a commit to abhinavsinghvi/stacktrace-gps that referenced this issue Oct 28, 2016
@eriwen
Copy link
Member

eriwen commented Dec 1, 2016

This should be fixed by 8815f85. Thanks @abhinavsinghvi!

@eriwen eriwen closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants