This repository was archived by the owner on Feb 16, 2024. It is now read-only.
Add first implementation of stacks according to ADR 21 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhennig
reviewed
Jun 13, 2022
stacks/druid-superset/druid.yaml
Outdated
| metadataStorageDatabase: | ||
| dbType: derby | ||
| connString: jdbc:derby://localhost:1527/var/druid/metadata.db;create=true | ||
| host: localhost # TODO why do i need to specify this? |
There was a problem hiding this comment.
Yes, this is not ideal, I think in the near future we want to have a common "SQLConnection" object to use instead of this
|
I ran the superset-druid-s3 stack and it works for me too 👍 |
|
Lars will invite for a brief discussion on this today |
|
Thanks for the review and confirmation that it works :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I proudly present the first working stack:
druid-superset-s3Use the following command to spin it up
releases.yamlis currently a bit hacky, as we haven't released operators for so long...