-
Notifications
You must be signed in to change notification settings - Fork 1
[Merged by Bors] - Implement stacks and services commands #36
Conversation
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments...will do some testing now. I think we need a more automated way to provide the product (e.g. druid-superset-s3) yamls.
Tested and works fine. The only thing i dislike with the service feature are the warnings if not all operators / crds are installed:
This is coming from kube-rs (kube-rs/kube#949, kube-rs/kube#948). In main.rs:
|
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Malte Sander <[email protected]>
…tl into access-services
I think i found a better solution. I'm using discovery to check if the ProductCRD is installed. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sigi and Sebastian finished their discussions before Sigi left for vacation, I am dismissing this so we do not have to wait until Sigi's return before merging.
Many thanks to all of you! |
bors r+ |
This PR adds two new subcommands: * Stacks to install ready-to-use product sets * Services which allows users to list and access the running services (#10) The structure of the `stacks.yaml` still needs to be discussed with @lfrancke and might be adopted to the porter.yaml style. Listing of services is a mechanism i came up with, so is ready to review as is :) To test the stack command run ``` cargo r --additional-stack-files stacks.yaml stack install druid-superset-s3 -k ``` To test the listing of services (this command was run after installing the stack `druid-superset-s3` and a bunch of other products) ``` cargo r -- services ls Finished dev [unoptimized + debuginfo] target(s) in 0.05s Running `target/debug/stackablectl services ls` PRODUCT NAME NAMESPACE ENDPOINTS EXTRA INFOS airflow airflow default webserver-airflow: http://172.18.0.4:31206 Admin user: airflow, password: airflow druid druid default router-http: http://172.18.0.4:32126 coordinator-http: http://172.18.0.4:30347 hbase simple-hbase default regionserver: 172.18.0.4:32413 ui: http://172.18.0.4:32051 metrics: 172.18.0.4:30504 hdfs simple-hdfs default datanode-default-0-metrics: 172.18.0.4:32607 datanode-default-0-data: 172.18.0.4:30655 datanode-default-0-http: http://172.18.0.4:32340 datanode-default-0-ipc: 172.18.0.4:31295 namenode-default-0-metrics: 172.18.0.3:31541 namenode-default-0-http: http://172.18.0.3:31669 namenode-default-0-rpc: 172.18.0.3:32286 journalnode-default-0-metrics: 172.18.0.5:30631 journalnode-default-0-http: http://172.18.0.5:31961 journalnode-default-0-https: https://172.18.0.5:30133 journalnode-default-0-rpc: 172.18.0.5:31222 hive simple-hive-derby default hive: 172.18.0.4:30560 metrics: 172.18.0.4:31796 superset superset default external-superset: http://172.18.0.3:30067 Admin user: admin, password: admin trino simple-trino default coordinator-http: http://172.18.0.5:31395 coordinator-metrics: 172.18.0.5:32214 zookeeper druid-zookeeper default zk: 172.18.0.3:32220 zookeeper simple-zk default zk: 172.18.0.5:32548 minio minio-druid default http: http://172.18.0.5:30054 Third party service console-http: http://172.18.0.5:31771 Admin user: root, password: rootroot ```
Pull request successfully merged into main. Build succeeded: |
This PR adds two new subcommands:
The structure of the
stacks.yaml
still needs to be discussed with @lfrancke and might be adopted to the porter.yaml style.Listing of services is a mechanism i came up with, so is ready to review as is :)
To test the stack command run
To test the listing of services (this command was run after installing the stack
druid-superset-s3
and a bunch of other products)