Skip to content

Add prepared logs to the logging test #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 4, 2024

Description

Add prepared logs to the logging test containing invalid log events

Tests stackabletech/operator-rs#802

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber siegfriedweber self-assigned this Jun 4, 2024
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jun 4, 2024

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jun 6, 2024

@siegfriedweber siegfriedweber requested a review from a team June 12, 2024 12:25
@siegfriedweber siegfriedweber marked this pull request as ready for review June 12, 2024 12:25
sbernauer
sbernauer previously approved these changes Jun 12, 2024
@sbernauer
Copy link
Member

Can we please also have a changelog entry that the logs are now fixed? I don't expect users to read the operator-rs changelog

@siegfriedweber siegfriedweber added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 44d8a6e Jun 13, 2024
32 checks passed
@siegfriedweber siegfriedweber deleted the fix/vector-log-processing branch June 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants