Skip to content

chore: Add shell.nix for all operators #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 21, 2024
Merged

chore: Add shell.nix for all operators #323

merged 11 commits into from
Feb 21, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 16, 2024

This is based on what I was doing in stackabletech/secret-operator#344, but to extend it out to all operators.

Important

Each operator will need to have Cargo.nix checked in to be able to make use of these changes. Otherwise they will get the following error when running nix-shell:

error: getting status of '.../Cargo.nix': No such file or directory

Run:

make regenerate-nix
git add Cargo.nix crate-hashes.json
git commit -m "add crate2nix generated files"

niv add stackabletech/beku.py
git add nix/source.json
git commit -m "add niv dependencies"

It includes some packages that are only needed for secret-operator:

  • They are supposed to already be discovered/provided by default.nix, but I can't get it working.
  • If we can't fix the above point, then perhaps we can call out to another nix file that lists additional packages needed by that operator (but then most of then would need to provide a basically empty extra nix file).

This will also skip spell-checking in listed generated files.

image


I'll go through the PRs this generates so I can add in the missing generated files.

### Products
- [ ] https://github.com/stackabletech/airflow-operator/pull/388
- [ ] https://github.com/stackabletech/druid-operator/pull/519
- [ ] https://github.com/stackabletech/hbase-operator/pull/456
- [ ] https://github.com/stackabletech/hdfs-operator/pull/476
- [ ] https://github.com/stackabletech/hive-operator/pull/417
- [ ] https://github.com/stackabletech/kafka-operator/pull/665
- [ ] https://github.com/stackabletech/nifi-operator/pull/575
- [ ] https://github.com/stackabletech/spark-k8s-operator/pull/360
- [ ] https://github.com/stackabletech/superset-operator/pull/458
- [ ] https://github.com/stackabletech/trino-operator/pull/540
- [ ] https://github.com/stackabletech/zookeeper-operator/pull/773
- [ ] https://github.com/stackabletech/commons-operator/pull/213
- [ ] https://github.com/stackabletech/listener-operator/pull/150
- [ ] https://github.com/stackabletech/opa-operator/pull/527
- [ ] https://github.com/stackabletech/secret-operator/pull/373
- [ ] https://github.com/stackabletech/edc-operator/pull/56
- [ ] https://github.com/stackabletech/hello-world-operator/pull/55

@NickLarsenNZ NickLarsenNZ requested a review from nightkr February 16, 2024 12:55
@NickLarsenNZ NickLarsenNZ changed the title Add shell.nix for all operators chore: Add shell.nix for all operators Feb 16, 2024
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review February 16, 2024 13:39
nightkr
nightkr previously approved these changes Feb 21, 2024
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise LGTM.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 5b720fb Feb 21, 2024
@NickLarsenNZ NickLarsenNZ deleted the nix-shell-for-all branch February 21, 2024 12:36
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Feb 21, 2024

@lfrancke, moving this back to In Progress to track the needed changes in each generated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants