Skip to content

Github Linguist ignore generated nix files #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 16, 2024

This change will stop generated nix files in the templated operators from being included in the stats, and diffs will be hidden by default (long files are anyway). More information in the linguist docs.

Semi-relevant discussion: stackabletech/secret-operator#344 (comment).

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Feb 16, 2024

I have not yet run a test against an operator, but would like some initial feedback.
I have tested it over the airflow operator. All changes expected.

@NickLarsenNZ NickLarsenNZ requested a review from nightkr February 16, 2024 10:28
@NickLarsenNZ NickLarsenNZ self-assigned this Feb 16, 2024
@NickLarsenNZ
Copy link
Member Author

... and to state my intention, I would also like to get a shell.nix into operator-templating, like I am trialing out with secret-operator: stackabletech/secret-operator#344

@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review February 16, 2024 10:47
NickLarsenNZ added a commit to stackabletech/secret-operator that referenced this pull request Feb 16, 2024
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Feb 20, 2024

Merging into #323 because these changes are needed to properly test the templating.

See 5262242

@NickLarsenNZ NickLarsenNZ deleted the linguist-ignore-generated branch February 20, 2024 11:36
@NickLarsenNZ NickLarsenNZ removed the request for review from nightkr February 20, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant