Skip to content

Fix race condition at TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix race condition at TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash #3081

merged 1 commit into from
Feb 28, 2024

Conversation

Wzy19930507
Copy link
Contributor

@Wzy19930507 Wzy19930507 commented Feb 28, 2024 •
edited
Loading

Fix race condition at TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash

Exception see:

TransactionalContainerTests > testBatchListenerRecoverAfterRollbackProcessorCrash() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "qux"
     but was: "baz"
        at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
        at [email protected]/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at [email protected]/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
        at app//org.springframework.kafka.listener.TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash(TransactionalContainerTests.java:1010)

@Wzy19930507 Wzy19930507 mentioned this pull request Feb 28, 2024
Merged
@sobychacko
Copy link
Contributor

@Wzy19930507 I Just want to make sure that this was a race condition since this test doesn't always fail.

@Wzy19930507
Copy link
Contributor Author

Wzy19930507 commented Feb 28, 2024 •
edited
Loading

@Wzy19930507 I Just want to make sure that this was a race condition since this test doesn't always fail.

Thanks for quick reply. Sorry i misunderstand your reply before. Yes it's race condition.

@Wzy19930507 Wzy19930507 changed the title Fix bug at TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash Fix race condition at TransactionalContainerTests.testBatchListenerRecoverAfterRollbackProcessorCrash Feb 28, 2024
@sobychacko sobychacko added this to the 3.2.0-M2 milestone Feb 28, 2024
@sobychacko sobychacko merged commit 8c3d656 into spring-projects:main Feb 28, 2024
@Wzy19930507 Wzy19930507 deleted the fix_bug_in_tct branch February 29, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.2.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@Wzy19930507 @sobychacko