GH-3049: Listener exceptions are not saved to the observation. #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit text |
artembilan
requested changes
Feb 28, 2024
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
Wzy19930507
changed the title
artembilan
requested changes
Feb 28, 2024
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Feb 28, 2024
| KafkaTemplate<Integer, String> errorTemplate(ProducerFactory<Integer, String> pf) { | ||
| KafkaTemplate<Integer, String> template = new KafkaTemplate<>(pf); | ||
| template.setObservationEnabled(true); | ||
| return template; |
There was a problem hiding this comment.
Looks like both of these new KafkaTemplate beans are just exactly the same what is template bean.
Any particular reason why do we need these two?
Why that template is not enough for new tests?
Thanks
There was a problem hiding this comment.
Just for test tag spring.kafka.template.name, is doesn't matter.
Is ok to unify the runtimeExceptionTemplate and errorTemplate into a throwableTemplate?
* Embedded the (original) exception into the observation, allowing downstream tracing code to handle it. * Add unit test for observation Error and RuntimeException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3049