Skip to content

GH-2059: expose adminTimeout property in EmbeddedKafka annotation #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2022
Merged

GH-2059: expose adminTimeout property in EmbeddedKafka annotation #2194

merged 3 commits into from
Mar 29, 2022

Conversation

breader124
Copy link
Contributor

No description provided.

@breader124 breader124 mentioned this pull request Mar 27, 2022
Closed
@garyrussell
Copy link
Contributor

Thanks; see the build report...

> Task :spring-kafka-test:checkstyleMain FAILED
Error: eckstyle] [ERROR] /home/runner/work/spring-kafka/spring-kafka/spring-kafka-test/src/main/java/org/springframework/kafka/test/context/EmbeddedKafka.java:25:8: Unused import - java.time.Duration. [UnusedImports]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':spring-kafka-test:checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/runner/work/spring-kafka/spring-kafka/spring-kafka-test/build/reports/checkstyle/main.html
  Checkstyle files with violations: 1
  Checkstyle violations by severity: [error:1]

You can run ./gradlew clean check to find these issues locally.

@breader124
Copy link
Contributor Author

It should be fine now

garyrussell
garyrussell reviewed Mar 29, 2022
View reviewed changes
spring-kafka-test/src/main/java/org/springframework/kafka/test/context/EmbeddedKafka.java Outdated
/**
* Timeout in seconds for admin operations (e.g. topic creation, close).
* @return default {@link EmbeddedKafkaBroker#DEFAULT_ADMIN_TIMEOUT}
* @since 3.0
Copy link
Contributor

@garyrussell garyrussell Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breader124 The 3.0 release is a long way off; we can back-port this to 2.8.5.

garyrussell
garyrussell approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Resolves https://github.com/spring-projects/spring-kafka/issues/2059 to a commit comment so that the issue auto-closes when we merge it.

@garyrussell garyrussell merged commit 408623c into spring-projects:main Mar 29, 2022
@garyrussell
Copy link
Contributor

Thanks for the contribution - looking forward to more - cherry-picked as 5650491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyrussell garyrussell garyrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breader124 @garyrussell