Skip to content

@EmbeddedKafka annotation doesn't expose adminTimeout property #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smoothello opened this issue Jan 4, 2022 · 4 comments
Closed

@EmbeddedKafka annotation doesn't expose adminTimeout property #2059

smoothello opened this issue Jan 4, 2022 · 4 comments
Assignees
@breader124
Labels
backport 2.8.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: enhancement
Milestone
3.0.0-M4

Comments

@smoothello
Copy link

smoothello commented Jan 4, 2022 •
edited
Loading

As per reply from Artem (Bilan) on stackoverflow (link), @embeddedkafka annotation would need to expose adminTimeout property.
Use case is when running multiple parallel integration test cases for different subprojects all using embeddedkafka, the default timeout value of 10sec end up being too short (please refer to stackoverflow for detail). reducing (or avoiding) parallelism ends up significantly extending test suite total execution time, and as such is not a valid option.
@garyrussell garyrussell added ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: enhancement labels Jan 4, 2022
@garyrussell garyrussell added this to the Backlog milestone Jan 4, 2022
@garyrussell
Copy link
Contributor

@ntjp You might also want to explore using a single embedded broker for all your tests.

See https://docs.spring.io/spring-kafka/docs/current/reference/html/#using-the-same-brokers-for-multiple-test-classes

@breader124
Copy link
Contributor

Hi @garyrussell, is this issue still waiting to be solved? If yes, could you please assign it to me? Thanks

@garyrussell
Copy link
Contributor

Thanks.

breader124 added a commit to breader124/spring-kafka that referenced this issue Mar 27, 2022
@breader124
spring-projectsGH-2059: expose adminTimeout property in EmbeddedKafka…
187d639 
… annotation
@breader124
Copy link
Contributor

Hi @garyrussell, I just created PR, you can find it here: #2194

breader124 added a commit to breader124/spring-kafka that referenced this issue Mar 29, 2022
@breader124
spring-projectsGH-2059: remove unused import
a7084c4
@garyrussell garyrussell modified the milestones: Backlog, 3.0.0-M4 Mar 29, 2022
breader124 added a commit to breader124/spring-kafka that referenced this issue Mar 29, 2022
@breader124
spring-projectsGH-2059: change since version param in added methods
b4fda65 
Resolves spring-projects#2059
garyrussell pushed a commit that referenced this issue Mar 29, 2022
@breader124 @garyrussell
GH-2059: adminTimeout property on @embeddedkafka
5650491 
* GH-2059: expose adminTimeout property in EmbeddedKafka annotation

* GH-2059: remove unused import

* GH-2059: change since version param in added methods

Resolves #2059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breader124 breader124

Labels
backport 2.8.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

No branches or pull requests
3 participants
@garyrussell @smoothello @breader124