-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revise @Poller usage to single entry in Messaging Annotations. #3746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
onobc
wants to merge
4
commits into
spring-projects:main
from
onobc:cbono/gh-3506-poller-single-entry
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright 2002-2021 the original author or authors. | ||
* Copyright 2002-2022 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
|
@@ -103,6 +103,7 @@ | |
* @author Mark Fisher | ||
* @author Artem Bilan | ||
* @author Gary Russell | ||
* @author Chris Bono | ||
*/ | ||
public abstract class AbstractMethodAnnotationPostProcessor<T extends Annotation> | ||
implements MethodAnnotationPostProcessor<T> { | ||
|
@@ -363,24 +364,26 @@ protected AbstractEndpoint createEndpoint(MessageHandler handler, @SuppressWarni | |
protected AbstractEndpoint doCreateEndpoint(MessageHandler handler, MessageChannel inputChannel, | ||
List<Annotation> annotations) { | ||
|
||
Poller[] pollers = MessagingAnnotationUtils.resolveAttribute(annotations, "poller", Poller[].class); | ||
Poller poller = MessagingAnnotationUtils.resolveAttribute(annotations, "poller", Poller.class); | ||
boolean pollerProvided = poller != null && !ValueConstants.DEFAULT_NONE.equals(poller.value()); | ||
|
||
Reactive reactive = MessagingAnnotationUtils.resolveAttribute(annotations, "reactive", Reactive.class); | ||
boolean reactiveProvided = reactive != null && !ValueConstants.DEFAULT_NONE.equals(reactive.value()); | ||
|
||
Assert.state(!reactiveProvided || ObjectUtils.isEmpty(pollers), | ||
Assert.state(!reactiveProvided || !pollerProvided, | ||
"The 'poller' and 'reactive' are mutually exclusive."); | ||
|
||
if (inputChannel instanceof Publisher || handler instanceof ReactiveMessageHandlerAdapter || reactiveProvided) { | ||
return reactiveStreamsConsumer(inputChannel, handler, reactiveProvided ? reactive : null); | ||
} | ||
else if (inputChannel instanceof SubscribableChannel) { | ||
Assert.state(ObjectUtils.isEmpty(pollers), () -> | ||
Assert.state(!pollerProvided, () -> | ||
"A '@Poller' should not be specified for Annotation-based " + | ||
"endpoint, since '" + inputChannel + "' is a SubscribableChannel (not pollable)."); | ||
return new EventDrivenConsumer((SubscribableChannel) inputChannel, handler); | ||
} | ||
else if (inputChannel instanceof PollableChannel) { | ||
return pollingConsumer(inputChannel, handler, pollers); | ||
return pollingConsumer(inputChannel, handler, poller); | ||
} | ||
else { | ||
throw new IllegalArgumentException("Unsupported 'inputChannel' type: '" | ||
|
@@ -414,19 +417,15 @@ private ReactiveStreamsConsumer reactiveStreamsConsumer(MessageChannel channel, | |
return reactiveStreamsConsumer; | ||
} | ||
|
||
private PollingConsumer pollingConsumer(MessageChannel inputChannel, MessageHandler handler, Poller[] pollers) { | ||
private PollingConsumer pollingConsumer(MessageChannel inputChannel, MessageHandler handler, Poller poller) { | ||
PollingConsumer pollingConsumer = new PollingConsumer((PollableChannel) inputChannel, handler); | ||
configurePollingEndpoint(pollingConsumer, pollers); | ||
configurePollingEndpoint(pollingConsumer, poller); | ||
return pollingConsumer; | ||
} | ||
|
||
protected void configurePollingEndpoint(AbstractPollingEndpoint pollingEndpoint, Poller[] pollers) { | ||
protected void configurePollingEndpoint(AbstractPollingEndpoint pollingEndpoint, Poller poller) { | ||
PollerMetadata pollerMetadata; | ||
if (!ObjectUtils.isEmpty(pollers)) { | ||
Assert.state(pollers.length == 1, | ||
"The 'poller' for an Annotation-based endpoint can have only one '@Poller'."); | ||
Poller poller = pollers[0]; | ||
|
||
if (poller != null && !ValueConstants.DEFAULT_NONE.equals(poller.value())) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DITTO |
||
String ref = poller.value(); | ||
String triggerRef = poller.trigger(); | ||
String executorRef = poller.taskExecutor(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.