Revise @Poller usage to single entry in Messaging Annotations. #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Mar 10, 2022
...ration-core/src/main/java/org/springframework/integration/util/MessagingAnnotationUtils.java
Outdated
Show resolved
Hide resolved
...ration-core/src/main/java/org/springframework/integration/util/MessagingAnnotationUtils.java
Outdated
Show resolved
Hide resolved
- Make annotation utils check for NONE more generic - Move docs to whats-new.adoc - Polish javadoc
onobc
force-pushed
the
cbono/gh-3506-poller-single-entry
branch
from
36cc028 to
c3be5bc
Compare
onobc
commented
Mar 10, 2022
artembilan
requested changes
Mar 10, 2022
artembilan
requested changes
Mar 10, 2022
...org/springframework/integration/config/annotation/AbstractMethodAnnotationPostProcessor.java
Outdated
Show resolved
Hide resolved
| "The 'poller' for an Annotation-based endpoint can have only one '@Poller'."); | ||
| Poller poller = pollers[0]; | ||
|
|
||
| if (poller != null && !ValueConstants.DEFAULT_NONE.equals(poller.value())) { |
- simplify docs - simplify isProvided checks
|
Merged as f3d3694 after some commit message clean up. Thank you, Chris, again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3506