Skip to content

Support AggregateReference in query derivation. #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Jul 1, 2021

!!! This PR builds on #992 and therefore contains the commits of #993 as well. Obviously they must not end up twice on main. Only pick the last commit after #993 is merged !!!

For a property of type AggregateReference one may provide an aggregate an AggregateReference or the id of the aggregate.

Closes #987

@schauder schauder requested review from gregturn and mp911de July 1, 2021 12:21
schauder added 3 commits July 2, 2021 14:27
For a property of type AggregateReference one may provide an aggregate, an AggregateReference, or the id of the aggregate.

Closes #987
@schauder schauder force-pushed the issue/987-query-derivation-w-aggregate-ref branch from 72fa300 to 1a56eb7 Compare July 2, 2021 13:43
mp911de pushed a commit that referenced this pull request Jul 15, 2021
For a property of type AggregateReference one may provide an aggregate, an AggregateReference, or the id of the aggregate.

Closes #987
Original pull request: #999.
mp911de added a commit that referenced this pull request Jul 15, 2021
Tweak method names. Rebase onto main. Convert issue references to GH- from hash prefixed ones. Remove final keyword from variable and parameter declarations.

Original pull request: #999.
See #987
@mp911de mp911de added the type: enhancement A general enhancement label Jul 15, 2021
@mp911de mp911de added this to the 2.3 M1 (2021.1.0) milestone Jul 15, 2021
@mp911de
Copy link
Member

mp911de commented Jul 15, 2021

That's merged and polished now.

@mp911de mp911de closed this Jul 15, 2021
@mp911de mp911de deleted the issue/987-query-derivation-w-aggregate-ref branch July 15, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AggregateReference in derived query methods
2 participants