Skip to content

Convert AggregateReference using Converters instead of custom code paths #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schauder opened this issue Jun 23, 2021 · 0 comments
Closed

Convert AggregateReference using Converters instead of custom code paths #992

schauder opened this issue Jun 23, 2021 · 0 comments
Assignees
@schauder
Labels
type: enhancement A general enhancement
Milestone
2.3 M1 (2021.1.0)

Comments

@schauder
Copy link
Contributor

No description provided.

@schauder schauder self-assigned this Jun 23, 2021
schauder added a commit that referenced this issue Jun 23, 2021
@schauder
Convert AggregateReference by converters instead of custom code paths.
887f17b 
Closes #992
@schauder schauder mentioned this issue Jun 23, 2021
Closed
This was referenced Jul 1, 2021
Open
Open
schauder added a commit that referenced this issue Jul 1, 2021
@schauder
Support AggregateReference in query derivation.
c55690f 
We register now reading and writing AggregateReferences instead of using custom code paths.
Thereby they get supported by normal handling of conversions including in query derivation.

For a property of type AggregateReference one may provide an aggregate an AggregateReference or the id of the aggregate.

Closes #992
@schauder schauder mentioned this issue Jul 1, 2021
Closed
schauder added a commit that referenced this issue Jul 2, 2021
@schauder
Implement advice from the code review.
642adee 
See #992
Original pull request #993
mp911de added a commit that referenced this issue Jul 15, 2021
@mp911de
Polishing.
4f4014d 
Hide actual converters by making these private classes, expose factory method to construct converters. Avoid stream API usage on converter code paths. Remove unused imports. Clean up tests.

Original pull request: #993.
See #992
@mp911de mp911de added the type: enhancement A general enhancement label Jul 15, 2021
@mp911de mp911de added this to the 2.3 M1 (2021.1.0) milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.3 M1 (2021.1.0)
2 participants
@schauder @mp911de