Only the contents of collections gets converted. #1356
Closed
+114
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an approximate timeline for when this PR will be merged/released? |
schauder
force-pushed
the
issue/1343-converter-for-iterable
branch
from
e4e7a2b to
365586c
Compare
mp911de
reviewed
Feb 23, 2023
| @@ -189,7 +190,7 @@ private void convertAndAddParameter(MapSqlParameterSource parameters, Parameter | |||
| Assert.notNull(type, "@Query parameter type could not be resolved"); | |||
|
|
|||
| JdbcValue jdbcValue; | |||
| if (value instanceof Iterable) { | |||
| if (value instanceof Collection && resolvableType.hasGenerics()) { | |||
There was a problem hiding this comment.
It would make sense to follow our general conventions to include Iterable and Streamable types but exclude custom domain types that implement Iterable.
See https://github.com/spring-projects/spring-data-commons/blob/main/src/main/java/org/springframework/data/util/TypeDiscoverer.java#L118-L126 for further reference. Also, we should consider CustomCollections to support usage of e.g. vavr collection types as follow up.
|
@mp911de I'd appreciate it if you could look into this. |
|
That's merged and backported now. |
mp911de
added
type: regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of Iterables that aren't collections will not be converted individually.
Closes #1343
Replaces #1345