Skip to content

Fix for #1343 #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hariohmprasath
Copy link
Contributor

Fix to check for both iterable and generic type before proceeding.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Fix to check for both iterable and hasGenerics before proceeding
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 3, 2022
@schauder
Copy link
Contributor

schauder commented Oct 4, 2022

Please add at least one test exercising this code.

@loolzaaa
Copy link

loolzaaa commented Oct 5, 2022

I think it is also necessary to take into account improvements for #1323

@schauder
Copy link
Contributor

Closing this in favor of #1356

@schauder schauder closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom converter not used for Iterable type from 2.4.1
4 participants