Skip to content

Fix to check for empty criteria #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix to check for empty criteria #1338

wants to merge 1 commit into from

Conversation

hariohmprasath
Copy link
Contributor

Code changes to check for both null and empty criteria before proceeding to where clause generation, so we dont fail with IllegalArgumentException

#1329

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@hariohmprasath
Fix to check for empty criteria
ac3efb3 
Code changes to check for both null and empty criteria before proceeding to where clause generation.

#1329
@hariohmprasath hariohmprasath mentioned this pull request Sep 25, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 25, 2022
schauder pushed a commit that referenced this pull request Sep 26, 2022
@hariohmprasath @schauder
Avoid exception for empty criteria.
9b65704 
Code changes to check for both null and empty criteria before proceeding to where clause generation avoids exception.

Closes #1329
Original pull request #1338
schauder added a commit that referenced this pull request Sep 26, 2022
@schauder
Polishing.
98ef3df 
Original pull request #1338
See #1329
@schauder
Copy link
Contributor

Thanks. That's polished and merged.

@schauder schauder closed this Sep 26, 2022
@schauder schauder added this to the 3.0 RC1 (2022.0.0) milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
3.0 RC1 (2022.0.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@hariohmprasath @schauder @spring-projects-issues