Cannot map empty Criteria

[holmofy]

spring data jdbc: spring-data-jdbc-3.0.0-M5.jar

controller

@GetMapping
public Page<Issue> index(Issue search, Pageable pageable) {
    return issueDao.findAll(Example.of(search), pageable);
}

request param:

This interface doesn't work like spring data jpa's findByExample method. A query with all conditions empty will report an error directly:

java.lang.IllegalArgumentException: Cannot map empty Criteria
	at org.springframework.data.jdbc.core.convert.QueryMapper.getMappedObject(QueryMapper.java:164)
	at org.springframework.data.jdbc.core.convert.SqlGenerator.applyCriteria(SqlGenerator.java:945)
	at org.springframework.data.jdbc.core.convert.SqlGenerator.lambda$applyQueryOnSelect$7(SqlGenerator.java:921)
	at java.base/java.util.Optional.map(Optional.java:260)
	at org.springframework.data.jdbc.core.convert.SqlGenerator.applyQueryOnSelect(SqlGenerator.java:921)
        ...

[hariohmprasath]

Hi @holmofy,
Looks like the code throws IllegalArgumentException if criteria.isEmpty(), checked part of:

org.springframework.data.jdbc.core.convert.QueryMapper#getMappedObject()

Updating the code according to the attached screenshot should resolve this issue and by if the criteria is empty all the records in the table will be returned falling back to JPA behavior in spring:

@schauder,
I have created a PR (#1338) with the additional test case to validate this scenario, please let me know your thoughts. Thanks

[holmofy]

Yep, that's the problem I'm having. Thank you so much for replying so quickly.

[schauder]

@holmofy Why did you close this issue? Was your problem resolved? Or was this in anticipation of the PR by @hariohmprasath ? If so, we'll close the issue only after the PR is merged.

Reopening in the assumption the later is the case.