Batch non-root inserts across aggregates #1211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
requested changes
Apr 5, 2022
...bc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateChangeExecutionContext.java
Outdated
Show resolved
Hide resolved
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java
Outdated
Show resolved
Hide resolved
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java
Outdated
Show resolved
Hide resolved
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java
Outdated
Show resolved
Hide resolved
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateTemplate.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/data/relational/core/conversion/MutableAggregateChange.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/data/relational/core/conversion/MutableAggregateChange.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/data/relational/core/conversion/MutableAggregateChange.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/data/relational/core/conversion/RelationalEntityDeleteWriter.java
Outdated
Show resolved
Hide resolved
| private void addDelete(DbAction.Delete<?> action) { | ||
|
|
||
| PersistentPropertyPath<RelationalPersistentProperty> propertyPath = action.getPropertyPath(); | ||
| deleteActions.merge(propertyPath, new ArrayList<>(singletonList(action)), (actions, defaultValue) -> { |
There was a problem hiding this comment.
Nit: Duplicate nested collection creation is costly.
… of SaveMergedAggregateChange.
+ Update #populateIdsIfNecessary return type from T to List<T>
…for batching root inserts as well.
ctailor2
force-pushed
the
issue/537-batch-ops-across-aggregates
branch
from
e80798f to
8ab97b9
Compare
|
MyBatis related tests fail. Previous builds didn't report those since they skipped the tests. 🤔 |
This was referenced Apr 22, 2022
schauder
pushed a commit
that referenced
this pull request
Jun 8, 2022
…anges into one. Remove behavior from WritingContext for creating InsertBatch in favor of SaveMergedAggregateChange. Update all save paths to use SaveMergedAggregateChange. + Update #populateIdsIfNecessary return type from T to List<T> Pull out an abstract BatchWithValue class from InsertBatch to use it for batching root inserts as well. Rename InsertBatch to BatchInsert Rename AggregateChangeWithRoot to RootAggregateChange. Original pull request #1211
schauder
added a commit
that referenced
this pull request
Jun 8, 2022
|
That's merged. Thanks for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #1159 that further batches non-root insert actions across multiple aggregates via
CrudRepository#saveAll.The hope is that these changes pave the way for follow-on work to further batch:
#saveAll#saveAll#deleteAll(Iterable<? extends T> entities)#deleteAll(Iterable<? extends T> entities).Related to #537