Skip to content

Improve performance for batch operations [DATAJDBC-314] #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Jan 4, 2019 · 8 comments
Closed

Improve performance for batch operations [DATAJDBC-314] #537

spring-projects-issues opened this issue Jan 4, 2019 · 8 comments
Assignees
@schauder @ctailor2
Labels
has: votes-jira in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Ioannis Daskalakis opened DATAJDBC-314 and commented

Currently, SimpleJdbcRepository batch operations (saveAll, deleteAll) are performed by iterating all instances and performing the operation for each instance separately.

Utilizing batching on the jdbc level (e.g. by utilizing NamedParameterJdbcOperations::batchUpdate) would offer significant performance improvements.

  

Issue Links:

  • DATAJDBC-328 Implement saveInBatch, deleteInBatch methods
    ("is duplicated by")

11 votes, 12 watchers
@spring-projects-issues
Copy link
Author

cn-src commented

Add batchInsert and batchDelete very good

@spring-projects-issues
Copy link
Author

deleted commented

Looks like duplicated by DATAJDBC-328

@spring-projects-issues spring-projects-issues added in: repository Repositories abstraction type: enhancement A general enhancement has: votes-jira labels Dec 31, 2020
@cemo
Copy link

cemo commented May 18, 2021

I think supporting batch operations is essential.

@ToddyuLi
Copy link

any plan on this? I need it too!!

@vtrusevich-incomm
Copy link

Are there any plans for this feature?

@dereknheiley
Copy link

How is this still not a thing? Where do i push a PR for it?

@schauder
Copy link
Contributor

@dereknheiley https://github.com/spring-projects/spring-data-jdbc/pulls
Also see https://github.com/spring-projects/spring-data-build/blob/main/CONTRIBUTING.adoc

This was referenced Feb 3, 2022
Closed
Closed
Closed
@schauder schauder added epic:batching in: mapping Mapping and conversion infrastructure and removed in: repository Repositories abstraction labels Feb 7, 2022
This was referenced Mar 17, 2022
Closed
Closed
@ctailor2 ctailor2 mentioned this issue Apr 1, 2022
Closed
@ctailor2 ctailor2 self-assigned this Apr 1, 2022
This was referenced Apr 22, 2022
Closed
Closed
Closed
Closed
schauder pushed a commit that referenced this issue Jun 20, 2022
@ctailor2 @schauder
Add DeleteBatchingAggregateChange to batch DeleteRoot actions.
1a283fa 
Original pull request #1231
See #537
schauder added a commit that referenced this issue Jun 20, 2022
@schauder
Polishing.
ed7853d 
Original pull request #1231
See #537
@schauder
Copy link
Contributor

schauder commented Jul 4, 2022

This got resolved by the various issue and PRs referencing this issue.

@schauder schauder closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

@ctailor2 ctailor2

Labels
has: votes-jira in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@cemo @schauder @dereknheiley @ctailor2 @spring-projects-issues @ToddyuLi @vtrusevich-incomm